Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile

[Anthony Liguori]

Riku Voipio wrote:
> On Wed, Mar 25, 2009 at 03:45:14PM -0300, Glauber Costa wrote:
>   
> > install -s is pretty and cute, but makes the binary get into the build
> > directory without any debug information. This is bad, and makes glommer
> > sad. Also, tools that attempt to extract that data, like fedora debuginfo
> > extractor, will fail.
> >     
>
> Fully ACK, but you'll want to fix that in Makefile.target too.
>   

Does anyone object to this?  I know Debian also carries a similar patch.

Regards,

Anthony Liguori

> > Signed-off-by: Glauber Costa <address@hidden>
> > ---
> >  Makefile |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 82fec80..859614b 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -251,7 +251,7 @@ endif
> >  install: all $(if $(BUILD_DOCS),install-doc)
> >         mkdir -p "$(DESTDIR)$(bindir)"
> >  ifneq ($(TOOLS),)
> > -       $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> > +       $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> >  endif
> >  ifneq ($(BLOBS),)
> >         mkdir -p "$(DESTDIR)$(datadir)"
> > --
> > 1.6.0.6
> >
> >
> >     
>
>