qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Document Qemu coding style


From: Lennart Sorensen
Subject: Re: [Qemu-devel] [PATCH] Document Qemu coding style
Date: Mon, 30 Mar 2009 17:45:47 -0400
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Mar 30, 2009 at 09:28:54PM +0300, Blue Swirl wrote:
> I'd remove this, braces are not used consistently for one statement blocks.

Then fix that.  Making the coding style worse just because some people
have failed to follow it is not the right solution.

> No, this is the K&R style. Quoting linux/Documentation/CodingStyle:
> 
> Heretic people all over the world have claimed that this inconsistency
> is ...  well ...  inconsistent, but all right-thinking people know that
> (a) K&R are _right_ and (b) K&R are right.  Besides, functions are
> special anyway (you can't nest them in C).

And Linus is wrong for not requiring braces at all times in the kernel. :)
I don't have much hope of convincing him of that, but he is still wrong.

-- 
Len Sorensen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]