Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns

[Kevin Wolf]

Am Donnerstag, 9. April 2009 19:54 schrieb Anthony Liguori:
> Kevin Wolf wrote:
> > This is what you get for using tabs. You deserve it. ;-)
> >
> > Seriously, I found this really annoying when I did the patch because
> > almost everything else in qemu has four spaces and I needed to change my
> > editor settings for just this file. But I still left indentation on four
> > characters, so this line did fit for me.
> >
> > I can either send a second version of the patch which fixes this line, or
> > we could have a patch which changes the indentation of the whole file to
> > four spaces (as specified in the coding style document). qemu-io might be
> > new enough to not destroy valuable svn blame information with such a
> > patch.
>
> The only reason I merged it as-is is because the code was derived from
> something else.  I didn't want to force a reindentation that would make
> it harder to keep the code synced against the upstream project.

That makes sense. However, I'm not sure if there is much left to sync with 
upstream? The code structure might be similar to upstream and maybe a few 
helper functions are the same (I'm not sure about that), but all in all the 
code seems to be pretty much specific to qemu.

So if there are any chances that we actually will merge upstream changes in 
future, I'm glad to change that one line. But if this is going to remain a 
purely theoretical option, I would prefer to change the indentation.

Kevin