qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns
Date: Fri, 10 Apr 2009 22:18:11 +0200
User-agent: KMail/1.9.5

Am Freitag, 10. April 2009 18:14 schrieb Christoph Hellwig:
> On Thu, Apr 09, 2009 at 07:07:45PM +0200, Kevin Wolf wrote:
> > I considered that, but actually it's not a simple flag anymore as soon as
> > it has a parameter. Don't know, you could argue either way.
>
> We have it that way in writev.  I don't really care too much either way,
> but I do care for consistency between the individual commands.

Sure, this is a good point. I can't see the Pflag in writev though, you just 
change the default pattern if -P is specified.

Anyway, we're discussing details. I'll change the name to Pflag and the line 
break so that it works with eight character tabs.  Anything else to do before 
it could be merged?

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]