Re: [Qemu-devel] [7234] Use a more natural order

[Anthony Liguori]

Lennart Sorensen wrote:
> On Thu, Apr 23, 2009 at 02:57:26PM -0500, Anthony Liguori wrote:
>   
> > In all fairness, I usually only do that when it's something I think  
> > people would comment on.  I probably would do a fix up like this by just  
> > committing.
> >
> > People miss things, it happens.  No process is going to prevent it  
> > happening 100% of the time.
> >     
>
> If you can't bother to compile test it, you shouldn't be commiting.
> Your time isn't worth that much more than everyone else that gets
> inconvinienced by the sloppy commit.
>
> That's a procedure that can certainly help.
>   

I was obviously referring to posting to the mailing list.  I have a set 
of compilation and unit tests that get run before every commit.

There are a lot of possible configuration options for QEMU.  Sometimes 
the build breaks for some combination of configuration options and this 
is a difficult thing to address in a robust way.  With a patch series, 
my scripts run through what I consider the most common set of 
configurations for each patch.  Right now, it usually takes a good 30 
minutes to go through a large series just to compile test with my 
default configurations.

Regards,

Anthony Liguori