[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEM
From: |
Lionel Landwerlin |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt |
Date: |
Mon, 27 Apr 2009 20:05:06 +0200 |
Le lundi 27 avril 2009 à 10:21 -0700, Nathan Froyd a écrit :
> On Sat, Apr 25, 2009 at 11:30:19PM +0200, Lionel Landwerlin wrote:
> > linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt
>
> Should these be TARGET_IP_* instead, or are they like the FUTEX_*
> constants and the same on every platform? If the latter, at the very
> least there should be explanatory comments somewhere--just making them
> TARGET_IP_* would be even better, IMHO.
>
> -Nathan
>
>
I'm agree too, I just did the way it was before...
--
Lionel Landwerlin <address@hidden>
- [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt, Lionel Landwerlin, 2009/04/25
- Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt, Nathan Froyd, 2009/04/27
- Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt,
Lionel Landwerlin <=
- Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt, Riku Voipio, 2009/04/29
- Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt, Jamie Lokier, 2009/04/29
- Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt, Riku Voipio, 2009/04/29
- Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt, Jamie Lokier, 2009/04/29
- Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt, Riku Voipio, 2009/04/29
- Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt, Jamie Lokier, 2009/04/29
- Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt, Lionel Landwerlin, 2009/04/29