Re: [Qemu-devel] [PATCH 0/3] linux-user: add ppc signal handling, v2

[malc]

On Wed, 13 May 2009, Laurent Desnogues wrote:

> On Wed, May 13, 2009 at 1:27 PM, malc <address@hidden> wrote:
> >
> > Done. BTW. here's another:
> >
> > target-ppc/op_helper.c:1977: warning: comparison is always false due to
> > limited range of data type
> >
> > This one is probably harmless, but still.. [The code is due to Aurelien
> > this time around though]
> 
> Are you sure?  I thought it was part of a patch sent by Nathan.

$ git show `git blame -L 1977 target-ppc/op_helper.c | head -1 | cut -d' ' -f1` 
| head -10

commit 00d3b8f59bb58e4c7ae52fc73d55d2f27e664443
Author: aurel32 <address@hidden>
Date:   Sun Jan 4 22:11:59 2009 +0000

    Add saturating arithmetic conversion functions for subsequent 
instructions.
    
    Signed-off-by: Nathan Froyd <address@hidden>
    Signed-off-by: Aurelien Jarno <address@hidden>
    
    git-svn-id: svn://svn.savannah.nongnu.org/qemu/address@hidden 
c046a42c-6fe2-441c-8c8c-71466251a162

So yeah you are right it's Nathan's after all.

> Anyway that indeed is harmless since it's due to this test (after
> macro expansion):
> 
>         if (0 && x < 0) {
> 
> BTW gcc 4.3.2 doesn't complain about it.

Looks that way.

-- 
mailto:address@hidden