[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp pa
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel |
Date: |
Thu, 28 May 2009 17:52:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Mark McLoughlin wrote:
> On Fri, 2009-05-08 at 12:34 +0200, Jan Kiszka wrote:
>> So far a couple of slirp-related parameters were expressed via
>> stand-alone command line options. This it inconsistent and unintuitive.
>> Moreover, it prevents both dynamically reconfigured (host_net_add/
>> delete) and multi-instance slirp.
>>
>> This patch refactors the configuration by turning -smb, -redir, -tftp
>> and -bootp as well as -net channel into options of "-net user". The old
>> stand-alone command line options are still processed, but no longer
>> advertised. This allows smooth migration of management applications to
>> to the new syntax and also the extension of that syntax later in this
>> series.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
> ....
>> diff --git a/slirp/main.h b/slirp/main.h
>> index ed51385..537c145 100644
>> --- a/slirp/main.h
>> +++ b/slirp/main.h
>> @@ -46,6 +46,8 @@ extern int tcp_keepintvl;
>> extern uint8_t client_ethaddr[6];
>> extern const char *slirp_special_ip;
>> extern int slirp_restrict;
>> +extern char tftp_prefix[PATH_MAX];
>> +extern char bootp_filename[PATH_MAX];
>
> This wouldn't build for me without including limits.h here
Please use v2 (see
http://permalink.gmane.org/gmane.comp.emulators.qemu/43080).
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
[Qemu-devel] [PATCH 06/11] slirp: Reorder initialization, Jan Kiszka, 2009/05/08
[Qemu-devel] [PATCH 02/11] net: Fix and improved ordered packet delivery, Jan Kiszka, 2009/05/08
[Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel, Jan Kiszka, 2009/05/08
- Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel, Mark McLoughlin, 2009/05/28
- Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel, Paul Brook, 2009/05/29
- Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel, Jan Kiszka, 2009/05/29
- Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel, Paul Brook, 2009/05/29
[Qemu-devel] [PATCH 01/11] net: Don't deliver to disabled interfaces in qemu_sendv_packet, Jan Kiszka, 2009/05/08
[Qemu-devel] [PATCH 09/11] slirp: Rework internal configuration, Jan Kiszka, 2009/05/08
[Qemu-devel] [PATCH 10/11] slirp: Rework external configuration interface, Jan Kiszka, 2009/05/08