Re: [Qemu-devel] [PATCH 7/7] virtio-net: Increase filter and control limits

[Michael S. Tsirkin]

On Fri, Jun 05, 2009 at 02:47:23PM -0600, Alex Williamson wrote:
> Increase the size of the perfect filter table and control queue depth.
> This should give us more headroom in the MAC filter and is known to be
> needed by at least one guest user.

Just curious - which guest is that?

> Increasing the control queue depth
> allows a guest to feed several commands back to back if they so desire
> rather than using the send and wait approach Linux uses.
> 
> Signed-off-by: Alex Williamson <address@hidden>
> ---
> 
>  hw/virtio-net.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/virtio-net.c b/hw/virtio-net.c
> index ecb58de..efaff04 100644
> --- a/hw/virtio-net.c
> +++ b/hw/virtio-net.c
> @@ -18,7 +18,7 @@
>  
>  #define VIRTIO_NET_VM_VERSION    10
>  
> -#define MAC_TABLE_ENTRIES    32
> +#define MAC_TABLE_ENTRIES    64
>  #define MAX_VLAN    (1 << 12)   /* Per 802.1Q definition */
>  
>  typedef struct VirtIONet
> @@ -685,7 +685,7 @@ VirtIODevice *virtio_net_init(DeviceState *dev)
>      n->vdev.reset = virtio_net_reset;
>      n->rx_vq = virtio_add_queue(&n->vdev, 256, virtio_net_handle_rx);
>      n->tx_vq = virtio_add_queue(&n->vdev, 256, virtio_net_handle_tx);
> -    n->ctrl_vq = virtio_add_queue(&n->vdev, 16, virtio_net_handle_ctrl);
> +    n->ctrl_vq = virtio_add_queue(&n->vdev, 64, virtio_net_handle_ctrl);
>      qdev_get_macaddr(dev, n->mac);
>      n->status = VIRTIO_NET_S_LINK_UP;
>      n->vc = qdev_get_vlan_client(dev,
> 
> 

-- 
MST