Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int.

[Anthony Liguori]

Samuel Thibault wrote:
> Anthony Liguori, le Thu 09 Jul 2009 14:07:47 -0500, a écrit :
>   
> > Isaku Yamahata wrote:
> >     
> > > use uint32_t for ioport port and value instead of int.
> > >  
> > >       
> > Why?
> >     
>
> In theory int could be only signed 16bit, so at least unsigned int could
> be needed for the port.

There's no platform that QEMU runs on that has a 16-bit integer and it's 
extraordinarily unlikely that there ever will be.

But the point is, patches need descriptive changelogs saying why there 
making a change, not just what the change is.

Regards,

Anthony Liguori