Re: [Qemu-devel] [PATCH 3/5] Remove setvbuf(<handle>, NULL, _IOLBF, 0) calls for Win32

[Filip Navara]

On Mon, Jul 27, 2009 at 3:21 PM, Daniel Jacobowitz<address@hidden> wrote:
> On Mon, Jul 27, 2009 at 10:02:04AM +0000, Filip Navara wrote:
>> On Win32 the setvbuf function requires the last parameter to be size between 
>> 2 and INT_MAX bytes, so the calls always failed. Since the whole point of 
>> the calls is to set line-buffered mode for the file handle and that's not 
>> supported on Win32 anyway, conditionally remove them.
>
> Should they be unbuffered where _IOLBF is not supported, then?  I
> assume the line buffering was to make them more useful in event of a
> crash.

I guess your assumption is correct. I'd be fine with using _IONBF for
the exec.c part, but setting it for stdout doesn't sound too useful to
me.

Best regards,
Filip Navara