|
| From: | Gerd Hoffmann |
| Subject: | Re: [Qemu-devel] [PATCH 2 of 3] a single vnc server surface |
| Date: | Wed, 29 Jul 2009 17:02:41 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 07/29/09 16:40, Stefano Stabellini wrote:
On Wed, 29 Jul 2009, Gerd Hoffmann wrote:I doubt you did any copyrect testing. It is broken in master[1], and this patch breaks it even more.No I didn't: I notice that your fix wasn't applied yet but can be easily applied on top of this patch.
No, it can't. Well, it will apply. It will also build with the small fixup. But the code isn't correct then.
The complete workflow of your patch was appearently designed without copyrect in mind. The whole point of copyrect is to avoid sending screen updates. Your patch doesn't handle that at all.
cheers, Gerd
| [Prev in Thread] | Current Thread | [Next in Thread] |