Re: [Qemu-devel] [PATCH] qemu_reserve_isa_irq()

[Gerd Hoffmann]

On 08/11/09 13:32, Jes Sorensen wrote:
> On 08/10/2009 08:57 PM, Anthony Liguori wrote:
> > Given the new isa qdev support, maybe it would be better to hook into
> > isa_connect_irq?
>
> Hi Anthony,
>
> In principle that would be good, the problem is just that the most of
> the code still brute force messages with the i8259 array directly,
> including the new ISA code. It really needs to be fixed to reference
> the ISA IRQ number and not the i8259 array directly :-(

How about making isa-bus.c own the i8259 array then?  We could pass it 
to isa_bus_new.  Then switch over to reference isa irqs by number.  That 
allows isa-bus to keep track of the allocations.  Maybe it makes sense 
to kill the sysbus-style isa_{init,connect}_irq split and have a irq bus 
property then.

cheers,
  Gerd