Re: [Qemu-devel] [PATCH 02/10] ide: split away ide-internal.h

[Natalia Portillo]

Maximum CD size is not 80 minutes.
Real firmwares of players are usually limited to 99 minutes 59 seconds  
75 frames, or unlimited.
I don't see the sense for this line.
Also why is the sector size fixed to 2048 when CDs can be of 2336 or  
2352 (data, without CRCs) bytes?

> +/* Some generally useful CD-ROM information */
> +#define CD_MINS                       80 /* max. minutes per CD */
> +#define CD_SECS                       60 /* seconds per minute */
> +#define CD_FRAMES                     75 /* frames per second */
> +#define CD_FRAMESIZE                2048 /* bytes per frame,  
> "cooked" mode */
> +#define CD_MAX_BYTES       (CD_MINS * CD_SECS * CD_FRAMES *  
> CD_FRAMESIZE)
> +#define CD_MAX_SECTORS     (CD_MAX_BYTES / 512)