qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/22] eepro100: cast a void * makes no sense

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 02/22] eepro100: cast a void * makes no sense
Date: Mon, 24 Aug 2009 16:05:10 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 
  static void nic_save(QEMUFile * f, void *opaque)
  {
-    EEPRO100State *s = (EEPRO100State *) opaque;
+    EEPRO100State *s = opaque;



I wrote these type casts, and I think they make sense.


Why?

There is no technical reason for it.
And in that case it IMHO doesn't make sense to keep the cast as documentation. 


If it is possible with no or very litte efforts to write
code which is C and C++ compatible, I prefer to do so.


Point being?  I doubt qemu will go C++ ...

cheers,
  Gerd
reply via email to
[Prev in Thread] Current Thread [Next in Thread]