Re: [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained?

[Anthony Liguori]

Avi Kivity wrote:
> On 09/10/2009 06:54 PM, Anthony Liguori wrote:
> > Avi Kivity wrote:
> > > On 09/10/2009 04:56 PM, Anthony Liguori wrote:
> > > > The problem is patch volume.  We often see hundreds of patches a 
> > > > day.  If typing a mail for each patch takes 2 minutes, that's 
> > > > potentially hours spent just on sending these mails.
> > >
> > > You exaggerate.  The average rate is 13 patches per calendar day.
> >
> > On list or committed?  There are a lot more on list than 13..
>
> You certainly shouldn't ack patches you don't commit!

But most spend time in staging.

Acking patches that go to master, that's perfectly fine to do.  The 
qemu-commits list does that and should CC the author directly so this 
should be happening.  It's acking things that go into staging that I 
think would be difficult and not necessarily productive.

> > This is goofy and is caused by improper patch submission.  But when 
> > people quote email threads in a commit message, I don't remove them.  
> > It don't see it as a problem.
>
> From long experience, most commit messages need to be edited.  People 
> rarely write commit messages that can be understood a year later, and 
> they don't know how 'git am' works.

I don't like editing patches.  I think it's unfair to the submitter to 
change their patch underneath of them.  I'd suggest providing feedback 
on the list to people who write bad commit messages and ask them to 
write better ones.  I try to limit the changes I make to resolving merge 
conflicts.

Regards,

Anthony Liguori