Re: [Qemu-devel] [PATCH 03/19] Remove double error message in qemu_option_set()

[Michael S. Tsirkin]

On Thu, Sep 10, 2009 at 04:18:45PM +0100, Mark McLoughlin wrote:
> qemu_opt_set() prints an error message in all failure cases, so
> qemu_set_option() doesn't need to print another error.
> 
> Signed-off-by: Mark McLoughlin <address@hidden>

Same comment about {} here

> ---
>  qemu-config.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/qemu-config.c b/qemu-config.c
> index 61e6ed1..733cc24 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -186,11 +186,9 @@ int qemu_set_option(const char *str)
>          return -1;
>      }
>  
> -    if (qemu_opt_set(opts, arg, str+offset+1) == -1) {
> -        fprintf(stderr, "failed to set \"%s\" for %s \"%s\"\n",
> -                arg, lists[i]->name, id);
> +    if (qemu_opt_set(opts, arg, str+offset+1) == -1)
>          return -1;
> -    }
> +
>      return 0;
>  }
>  
> -- 
> 1.6.2.5
> 
>