[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting |
Date: |
Mon, 23 Nov 2009 13:26:09 +0000 |
User-agent: |
KMail/1.12.2 (Linux/2.6.30-2-amd64; KDE/4.3.2; x86_64; ; ) |
On Monday 23 November 2009, Gerd Hoffmann wrote:
> On 11/20/09 18:41, Paul Brook wrote:
> > On Tuesday 17 November 2009, Gerd Hoffmann wrote:
> >> Add a greeting string to CharDriverState which is printed after
> >> initialization. Used to have the qemu vc consoles labeled. This
> >> way we can avoid walking all the chardevs a second time after
> >> initialization just to print the greeting.
> >
> > I think "greeting" is propagating a bad idea into new code. Much better
> > would be some form of ID and/or human readable description that can also
> > be used elsewhere.
>
> The naming is only one part of the problem. The second part is that the
> greeting is printed only for the 'vc' backend (where you really need it
> because there is no other way to figure what chardev you are looking at
> when switching screens via Ctrl-Alt-<nr>).
>
> There already is a 'label' field. So we could add a flag instead of a
> string, then do:
>
> if (chr->want_greeting)
> qemu_chr_printf(chr, "%s console\n", chr->label);
>
> How about this?
I thinking more that this should be done by the character backend itself. For
example, the "graphical" consoles should probably be putting this as part of
the window title rather than having the interface layer randomly send extra
characters in connect.
Paul
- [Qemu-devel] [PATCH 0/9] fixup default device handling., Gerd Hoffmann, 2009/11/17
- [Qemu-devel] [PATCH 2/9] default devices: core code & serial lines., Gerd Hoffmann, 2009/11/17
- [Qemu-devel] [PATCH 1/9] chardev: add greeting, Gerd Hoffmann, 2009/11/17
- Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting, Markus Armbruster, 2009/11/20
- Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting, Paul Brook, 2009/11/20
- Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting, Gerd Hoffmann, 2009/11/23
- Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting,
Paul Brook <=
- Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting, Gerd Hoffmann, 2009/11/23
- Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting, Paul Brook, 2009/11/23
- Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting, Daniel P. Berrange, 2009/11/23
- Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting, Anthony Liguori, 2009/11/23
- Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting, Gerd Hoffmann, 2009/11/23
[Qemu-devel] [PATCH 4/9] default devices: monitor, Gerd Hoffmann, 2009/11/17
[Qemu-devel] [PATCH 3/9] default devices: parallel port, Gerd Hoffmann, 2009/11/17
[Qemu-devel] [PATCH 8/9] default devices: drives, Gerd Hoffmann, 2009/11/17