|
| From: | Jan Kiszka |
| Subject: | [Qemu-devel] Re: [PATCH v2 05/11] tell kernel about all registers instead of just mp_state |
| Date: | Wed, 02 Dec 2009 13:10:22 +0100 |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Glauber Costa wrote:
>>> +{
>>> + if (kvm_enabled()) {
>> Is this ever called or intended to be called when kvm is disabled?
>>
>>> + kvm_cpu_flush_state(env);
>>> + }
>
> I don't think so. But this is here for consistency with its synchronize
> brother.
Ack. As soon as someone starts to use this generic service outside code
that is only built under CONFIG_KVM or called when kvm is enabled,
things will break.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
| [Prev in Thread] | Current Thread | [Next in Thread] |