[Qemu-devel] Re: [FOR 0.12 PATCH v3 05/21] default devices: core code & serial lines.

[Alexander Graf]

On 07.12.2009, at 14:27, Gerd Hoffmann wrote:

> On 12/07/09 13:52, Alexander Graf wrote:
>>> diff --git a/vl.c b/vl.c index 24d5d92..eca4eee 100644 --- a/vl.c
>>> +++ b/vl.c @@ -271,6 +271,30 @@ uint8_t qemu_uuid[16]; static
>>> QEMUBootSetHandler *boot_set_handler; static void
>>> *boot_set_opaque;
>>> 
>>> +static int default_serial = 1;
>> 
>> Default variables belong in the machine description IMHO. On S390, we
>> can't create serial, parallel or vga (or any MMIO/PIO requiring)
>> devices.
> 
> See last patch of this series.  Moving that into the machine description is 
> certainly worth looking at.  For now I'm happy that the #ifdef S390 code for 
> the default virtio console is down to just two lines.

Would it be that hard to move the list of default devices to the machine 
description? You could probably still keep the default_xxx variables in vl.c, 
but access them from e.g. pc.c.

Alex