Re: [Qemu-devel] Re: [PATCH] fix tool/libuser makefile race

[Andreas Färber]

Am 20.12.2009 um 19:38 schrieb Paolo Bonzini:

> On 12/20/2009 07:30 PM, Andreas Färber wrote:
> > Am 20.12.2009 um 19:22 schrieb Paolo Bonzini:
> >
> > > On 12/18/2009 07:59 PM, Andreas Färber wrote:
> > > > Think of my porposed Makefile patch!
> > >
> > > Which one?
> >
> > In particular my add-on patch for libuser.a, which tackled exactly  
> > that
> > issue:
> >
> > http://www.mail-archive.com/address@hidden/msg20948.html
>
> Ah, thanks.  Just to be clear, this issue was on Linux, not on  
> Solaris.  It is completely unrelated to --whole-archive and is a  
> real bug.

I did understand that. My patch was for Linux (there being no solaris- 
user) and acknowledged that there is such an unexpected mixture of  
libuser.a and libqemu_common.a object files, so it wasn't an all new  
discovery now.
I didn't attempt to change that behavior though, just Made It Work(tm)  
for regular builds.

Since we're bound to GNU make anyway, I have no objections to your  
patch if it works.

Andreas