[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

[Michael S. Tsirkin]

On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote:
> Michael S. Tsirkin schrieb:
> > On Sun, Feb 14, 2010 at 05:16:14PM +0100, Stefan Weil wrote:
> >   
> >> All eepro100 devices work with drivers which
> >> only use basic features.
> >>
> >> They were tested with gpxe boot.
> >>
> >> Signed-off-by: Stefan Weil <address@hidden>
> >> ---
> >>  hw/pci.c |   18 ++++++++++++++++++
> >>  1 files changed, 18 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/hw/pci.c b/hw/pci.c
> >> index eb2043e..1ba3f92 100644
> >> --- a/hw/pci.c
> >> +++ b/hw/pci.c
> >> @@ -1436,9 +1436,18 @@ void do_pci_info(Monitor *mon, QObject **ret_data)
> >>  
> >>  static const char * const pci_nic_models[] = {
> >>      "ne2k_pci",
> >> +    "i82550",
> >>      "i82551",
> >> +    "i82557a",
> >>      "i82557b",
> >> +    "i82557c",
> >> +    "i82558a",
> >> +    "i82558b",
> >> +    "i82559a",
> >> +    "i82559b",
> >> +    "i82559c",
> >>      "i82559er",
> >> +    "i82562",
> >>      "rtl8139",
> >>      "e1000",
> >>      "pcnet",
> >> @@ -1448,9 +1457,18 @@ static const char * const pci_nic_models[] = {
> >>  
> >>  static const char * const pci_nic_names[] = {
> >>      "ne2k_pci",
> >> +    "i82550",
> >>      "i82551",
> >> +    "i82557a",
> >>      "i82557b",
> >> +    "i82557c",
> >> +    "i82558a",
> >> +    "i82558b",
> >> +    "i82559a",
> >> +    "i82559b",
> >> +    "i82559c",
> >>      "i82559er",
> >> +    "i82562",
> >>      "rtl8139",
> >>      "e1000",
> >>      "pcnet",
> >>     
> >
> > One wonders: would it be cleaner to have a single eepro100 device
> > with specific model as qdev option?
> 
> Technically that would be possible, too.
> You could even have a single pci ethernet device and
> specify vendor and device id as qdev options.
> 
> I prefer the "official" device names which are also
> used in the Intel documentation. eepro100 or e100
> are marketing names (more of them exist).
> 
> Please note that this patch was marked as optional.
> The arrays pci_nic_names and pci_nic_models are
> not really needed, and as soon as the table of available
> nics is automatically derived from the device information,
> all variants of i825xx are supported automatically.
> 
> Regards
> Stefan Weil


Gerd, any input on this patch?

-- 
MST