[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in hu
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor |
Date: |
Fri, 05 Mar 2010 17:43:40 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Thu, 4 Mar 2010 17:50:20 -0300
> Luiz Capitulino <address@hidden> wrote:
>
>> On Thu, 4 Mar 2010 16:56:49 +0100
>> Markus Armbruster <address@hidden> wrote:
>>
>> > While fully converted handlers are not supposed to print anything when
>> > running in a QMP monitor, they are free to print in a human monitor.
>>
>> I disagree.
>
> I've talked to Markus by irc about this one and he convinced me that
> this is the best solution for the immediate term.
>
> Actually, I found out that only error is printed in the human monitor
> (through qerror_report()) so this is not as serious as I thought at first.
In case I confused not just you: the patch does not affect QMP monitors
at all.
I wish I had explained this better. Let me retry: the patch provides
for partially converted handlers. Without it, CONFIG_DEBUG_MONITOR
cries bloody murder, and converted errors get delayed until after all
output from the not-yet-converted parts of the handler.
For instance, it takes me four steps to fully convert do_device_add().
I want all the partially converted intermediate versions to work.
Even more compelling is the case of utility functions: I want to be able
to convert a function to QError without having to convert all the
handlers using it to QError / QObject in the same commit, because doing
that would result in an unreviewable hairball of a patch.
> So, I won't nack it and the bigger mid-term discussion we should have
> is whether or not it's ok to mix qerror_report(), error_printf() &
> friends in handlers.
I think mixing is both unavoidable and harmless in intermediate
conversion steps.
Whether we want to allow stuff like error_printf_unless_qmp() in the
final state is a separate and valid question. error_printf_unless_qmp()
solved the problem at hand for me, but of course I'm open to other
ideas. I don't think delaying this series could help with that, though.
- [Qemu-devel] [PATCH 22/50] error: Track locations on command line, (continued)
- [Qemu-devel] [PATCH 22/50] error: Track locations on command line, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 48/50] monitor: New argument type 'O', Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 29/50] error: Polish human-readable error descriptions, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 21/50] QemuOpts: Fix qemu_config_parse() to catch file read errors, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 32/50] qdev: convert setting device properties to QError, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 28/50] error: Let converted handlers print in human monitor, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 44/50] error: Convert do_device_add() to QError, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 37/50] qdev: Convert qbus_find() to QError, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 43/50] Revert "qdev: Use QError for 'device not found' error", Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 33/50] qdev: Relax parsing of bus option, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 50/50] monitor: convert do_device_add() to QObject, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 27/50] monitor: New monitor_cur_is_qmp(), Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 30/50] error: New QERR_PROPERTY_NOT_FOUND, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 25/50] qdev: Hide "no_user" devices from users, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 36/50] error: New QERR_DEVICE_NO_BUS, Markus Armbruster, 2010/03/04