[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/4] monitor: New argument type 'b'
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 2/4] monitor: New argument type 'b' |
Date: |
Wed, 24 Mar 2010 16:31:36 -0300 |
On Tue, 23 Mar 2010 11:27:56 +0100
Markus Armbruster <address@hidden> wrote:
> This is a boolean value. Human monitor accepts "on" or "off".
> Consistent with option parsing (see parse_option_bool()).
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> monitor.c | 31 +++++++++++++++++++++++++++++++
> 1 files changed, 31 insertions(+), 0 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 3ce9a4e..47b68a2 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -85,6 +85,8 @@
> *
> * '?' optional type (for all types, except '/')
> * '.' other form of optional type (for 'i' and 'l')
> + * 'b' boolean
> + * user mode accepts "on" or "off"
> * '-' optional parameter (eg. '-f')
> *
> */
> @@ -3841,6 +3843,29 @@ static const mon_cmd_t *monitor_parse_command(Monitor
> *mon,
> qdict_put(qdict, key, qfloat_from_double(val));
> }
> break;
> + case 'b':
> + {
> + const char *beg;
> + int val;
> +
> + while (qemu_isspace(*p)) {
> + p++;
> + }
> + beg = p;
> + while (qemu_isgraph(*p)) {
> + p++;
> + }
> + if (!strncmp(beg, "on", p - beg)) {
> + val = 1;
> + } else if (!strncmp(beg, "off", p - beg)) {
> + val = 0;
> + } else {
> + monitor_printf(mon, "Expected 'on' or 'off'\n");
> + goto fail;
> + }
This will make 'on' be the default when no on/off is specified, is that
your intention? I'm wondering if this can cause problems when you add
optional support for it and mixes it with other arguments.
> + qdict_put(qdict, key, qbool_from_int(val));
> + }
> + break;
> case '-':
> {
> const char *tmp = p;
> @@ -4322,6 +4347,12 @@ static int check_arg(const CmdArgs *cmd_args, QDict
> *args)
> return -1;
> }
> break;
> + case 'b':
> + if (qobject_type(value) != QTYPE_QBOOL) {
> + qerror_report(QERR_INVALID_PARAMETER_TYPE, name, "bool");
> + return -1;
> + }
> + break;
> case '-':
> if (qobject_type(value) != QTYPE_QINT &&
> qobject_type(value) != QTYPE_QBOOL) {
[Qemu-devel] [PATCH 4/4] monitor: Convert do_set_link() to QObject, QError, Markus Armbruster, 2010/03/23
[Qemu-devel] [PATCH 1/4] monitor: Rename argument type 'b' to 'f', Markus Armbruster, 2010/03/23
[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError, Luiz Capitulino, 2010/03/24