qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 2/2] Make kvm_enabled unavailable to non-target


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 2/2] Make kvm_enabled unavailable to non-target devices
Date: Fri, 02 Apr 2010 18:47:51 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3


+#pragma GCC poison kvm_allowed
+#pragma GCC poison kvm_enabled

  kvm_enabled() is a macro.  I dont' think this poison pragma is actually
meaningful.

I'm not familiar with poison pragmas, but actually poisoning only
kvm_allowed didn't work.

Indeed, macro expansions are explicitly allowed to use poisoned identifiers (and on the contrary macro names count towards poisoning errors).

IMO kvm_allowed should be left unpoisoned.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]