[Qemu-devel] Re: [PATCH 2/2] Make kvm_enabled unavailable to non-target devices

[Anthony Liguori]

On 04/02/2010 11:47 AM, Paolo Bonzini wrote:
> > > > +#pragma GCC poison kvm_allowed
> > > > +#pragma GCC poison kvm_enabled
> > >
> > >   kvm_enabled() is a macro.  I dont' think this poison pragma is 
> > > actually
> > > meaningful.
> >
> > I'm not familiar with poison pragmas, but actually poisoning only
> > kvm_allowed didn't work.
>
> Indeed, macro expansions are explicitly allowed to use poisoned 
> identifiers (and on the contrary macro names count towards poisoning 
> errors).
>
> IMO kvm_allowed should be left unpoisoned.

Interesting, thanks.

Regards,

Anthony Liguori

> Paolo