qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [RfC PATCH 08/11] spice: add qxl device


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [RfC PATCH 08/11] spice: add qxl device
Date: Thu, 15 Apr 2010 01:08:06 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3

On 04/14/2010 06:52 PM, Blue Swirl wrote:
On 4/14/10, Gerd Hoffmann<address@hidden>  wrote:
  +static inline void atomic_or(uint32_t *var, uint32_t add)
  +{
  +   __asm__ __volatile__ ("lock; orl %1, %0" : "+m" (*var) : "r" (add) : 
"memory");
  +}

This will break on non-x86 hosts.

I'd just use __sync_fetch_and_or here.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]