Re: [Qemu-devel] [PATCH 2/2] target-ppc: fix interrupt vectors for MPC603 and e300

[Alexander Graf]

On 21.04.2010, at 11:21, Thomas Monjalon wrote:

> From: Thomas Monjalon <address@hidden>
> 
> The vectors are listed
>    - in the chapter 1.3.3.2 (Implementation-Specific Interrupt Model)
>      of the e300 datasheet [e300CORERM] and
>    - in the chapter 3.5.2 (PowerPC 603 Microprocessor Exception Model)
>      of the MPC603 datasheet.
> 
> As e300 inherits from MPC603, init_excp_e300() calls init_excp_603().
> 
> Signed-off-by: Thomas Monjalon <address@hidden>
> ---
> target-ppc/translate_init.c |   13 +++++++++++--
> 1 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 9e42831..f3e266d 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -2853,7 +2853,16 @@ static void init_excp_603 (CPUPPCState *env)
>     env->excp_vectors[POWERPC_EXCP_SMI]      = 0x00001400;
>     env->hreset_excp_prefix = 0x00000000UL;
>     /* Hardware reset vector */
> -    env->hreset_vector = 0xFFFFFFFCUL;
> +    env->hreset_vector = 0x00000100UL;

Are you 100% sure this is correct? IIRC the reset vector is dictated by the CPU 
initialization sequence, so there's no hardwired value here really.


Btw - what do you use to test your patches?


Alex