|
From: | Avi Kivity |
Subject: | [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots |
Date: | Sun, 25 Apr 2010 15:33:03 +0300 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 |
On 04/24/2010 10:34 AM, Jan Kiszka wrote:
Marcelo Tosatti wrote:Otherwise there is no way to differentiate between global and slot specific logging, so for example vga dirty log start migration start migration fail Disables dirty logging for the vga slot.This is not true (unless there is a bug): Migration logging is tracked via KVMState::migration_log and vga logging via KVMSlot::flags. Both are merged in kvm_set_user_memory_region. Thus no such change is required for upstream.
It's still a good idea. The current API assumes that there will be only one slot-based client (or that multiple clients will keep the refcount themselves).
After the bytemap -> multiple bitmaps conversion this can be extended to each client getting its own bitmap (and therefore, s/refcount/list of bitmaps/ and s/!refcount/list_empty()/).
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |