[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/5] scsi-disk: Clear aiocb on read completion
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH 2/5] scsi-disk: Clear aiocb on read completion |
Date: |
Tue, 4 May 2010 14:21:00 +0200 |
Once the I/O completion callback returned, aiocb will be released by the
controller. So we have to clear the reference not only in
scsi_write_complete, but also in scsi_read_complete. Otherwise we risk
inconsistencies when a reset hits us before the related request is
released.
Signed-off-by: Jan Kiszka <address@hidden>
---
hw/scsi-disk.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index b8d805f..4d20919 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -125,6 +125,8 @@ static void scsi_read_complete(void * opaque, int ret)
{
SCSIDiskReq *r = (SCSIDiskReq *)opaque;
+ r->req.aiocb = NULL;
+
if (ret) {
DPRINTF("IO error\n");
r->req.bus->complete(r->req.bus, SCSI_REASON_DATA, r->req.tag, 0);
--
1.6.0.2
- [Qemu-devel] [PATCH 0/5] scsi: More reset and hotplug fixes, Jan Kiszka, 2010/05/04
- [Qemu-devel] [PATCH 4/5] lsi: Adjust some register reset values, Jan Kiszka, 2010/05/04
- [Qemu-devel] [PATCH 5/5] lsi: Handle removal of selected devices, Jan Kiszka, 2010/05/04
- [Qemu-devel] [PATCH 3/5] lsi: Purge message queue on reset, Jan Kiszka, 2010/05/04
- [Qemu-devel] [PATCH 1/5] SCSI: Add disk reset handler, Jan Kiszka, 2010/05/04
- [Qemu-devel] [PATCH 2/5] scsi-disk: Clear aiocb on read completion,
Jan Kiszka <=
- [Qemu-devel] Re: [PATCH 0/5] scsi: More reset and hotplug fixes, Gerd Hoffmann, 2010/05/04