[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/2] Add no-op aio emulation stub
|
From: |
Kevin Wolf |
|
Subject: |
[Qemu-devel] Re: [PATCH 1/2] Add no-op aio emulation stub |
|
Date: |
Fri, 14 May 2010 15:12:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 |
Am 13.05.2010 01:36, schrieb Alexander Graf:
> We need to be able to do nothing in AIO fashion. Since I suspect this
> could be useful for more cases than the non flushing, I figured I'd
> create a new function that does everything AIO-like, but doesn't do
> anything.
>
> Signed-off-by: Alexander Graf <address@hidden>
This isn't bisectable:
cc1: warnings being treated as errors
block.c:2208: error: 'bdrv_aio_noop_em' defined but not used
Maybe put everything in one patch, it's small enough now. Also, in
qemu-options.hx you could explain what volatile actually means. Below
the line that you change there are some paragraphs that explain the
behaviour for each value.
Other than that the series looks good to me. I'm not sure if Anthony is
already convinced, though. Everyone else seems to agree with the
intention of the series.
Kevin