[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings |
|
Date: |
Tue, 18 May 2010 11:56:35 +0200 |
On 18.05.2010, at 11:53, Corentin Chary wrote:
> On Tue, May 18, 2010 at 11:19 AM, Alexander Graf <address@hidden> wrote:
>>
>> On 18.05.2010, at 09:31, Corentin Chary wrote:
>>
>>> Signed-off-by: Corentin Chary <address@hidden>
>>
>> I'm also missing a cover letter explaining what your patch set does. As a
>> general rule of thumb, whenever your patch set spans more than 2 patches, a
>> cover letter is really helpful. To generate one, use git-format-patch
>> --cover-letter.
>>
>>
>> Alex
>>
>>
>>
>
> There is a cover-letter, but I accidentally put a '\n' and the
> beginning ( see
> http://thread.gmane.org/gmane.comp.emulators.qemu/70495 ).
I see :). Sounds like you should just rework all the patch descriptions so
people actually know what's going on within the patch without reading it and
then give it a go for v2.
Alex
- [Qemu-devel] [PATCH 06/10] vnc: add support for tight fill encoding, (continued)
- [Qemu-devel] [PATCH 06/10] vnc: add support for tight fill encoding, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 03/10] vnc: only use a single zlib stream, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 04/10] vnc: adjust compression zstream level, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 02/10] vnc: really call zlib if we want zlib, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 01/10] vnc: refactor set_encodings, Corentin Chary, 2010/05/18
- [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings, Alexander Graf, 2010/05/18