Re: [Qemu-devel] [PATCH v2 02/15] qdev: Fix scanning across single-bus devices

[Gerd Hoffmann]

On 05/29/10 09:38, Markus Armbruster wrote:
> [cc: kraxel]
>
> Jan Kiszka<address@hidden>  writes:
>
> > From: Jan Kiszka<address@hidden>
> >
> > As long as we allow /dev.1 as shortcut for /dev1/bus1, we also have to
> > make sure that /dev1/dev2 works for /dev1/bus1/dev2/bus2 - as long as
> > there is only one child bus per device.
>
> We auto-root a path not starting with '/' via convention "first
> component is ID then" (I like that).  We auto-complete a path ending
> with a device when we want a bus (a bit too clever).

... only if there is a single child bus only (i.e. it isn't ambiguous). 
 Which is the common case though.

> Auto-inserting bus
> names in the middle is too clever by half!

Yea.  I have to agree here.  It can only work reliably if you make sure 
all your devices have unique ids.  In which case there is no need to 
reference dev1 at all, you can just use the "first component is ID then" 
mechanism for dev2.

cheers,
  Gerd