Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

[Paul Brook]

> diff --git a/hw/realview.c b/hw/realview.c
> index a36bdbe..8dcef80 100644
> --- a/hw/realview.c
> +++ b/hw/realview.c
> @@ -444,9 +444,9 @@ static QEMUMachine realview_eb_mpcore_machine = {
>      .init = realview_eb_mpcore_init,
>      .opts_default = (QemuOptValue[]) {
>          QOPT_VALUE("default_drive", "scsi"),
> +        QOPT_VALUE("max_cpus", "4"),
>          { /* end of list */ }
>      },
> -    .max_cpus = 4,
>  };

By my reading this allows the user to modify this value. If so it is wrong. 

This is a fundamental property/limitation of the hardware. Expect qemu to 
crash if the value is modified.

Paul