[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config |
Date: |
Sat, 12 Jun 2010 16:37:58 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote:
> Aurelien Jarno wrote:
> > On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <address@hidden>
> >>
> >> Only match on true dir variable assignments, avoid generating garbage
> >> due to the "# Configured with: ..." line which may contain "*dir=" as
> >> well.
> >
> > Wouldn't it be better to skip all lines starting with '#', as this
> > problem might happen again after some more changes?
> >
> > Or maybe we should do both.
>
> This is what the patch (implicitly) does.
Yes, but only for this line. What I mean is something more generic
like:
"#"*) # comment
continue
;;
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net