Re: [Qemu-devel] Re: [PATCH] Disable O_DIRECT for physical CDROM/DVD drives

[Jes Sorensen]

On 07/20/10 18:09, Kevin Wolf wrote:
> Am 20.07.2010 17:40, schrieb Anthony Liguori:
>> Wouldn't a better solution be to have a cdrom_read/cdrom_write hook that 
>> did the appropriate bouncing?
> 
> We already have code that does some bouncing, we'd just need to teach it
> to use different sizes than 512. Duplicating everything wouldn't be a
> nice solution.

The problem is that it is quite hard to detect properly and there are
cases where we can get false positives, plus it would require cleaning
up the code to handle variable sector sizes. The latter is probably a
good thing, and if/when it happens, we can remove this.

Cheers,
Jes