Re: [Qemu-devel] [PATCH] savevm: Fix memory leak of compat struct

[Aurelien Jarno]

On Wed, Jul 21, 2010 at 08:35:31AM -0600, Alex Williamson wrote:
> Forgot to check for and free these.
> 
> Found-by: Zachary Amsden <address@hidden>
> Signed-off-by: Alex Williamson <address@hidden>
> ---
> 
>  0.13 Candidate
> 
>  savevm.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

Thanks, applied.

> diff --git a/savevm.c b/savevm.c
> index ee27989..1612794 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1126,6 +1126,9 @@ void unregister_savevm(DeviceState *dev, const char 
> *idstr, void *opaque)
>      QTAILQ_FOREACH_SAFE(se, &savevm_handlers, entry, new_se) {
>          if (strcmp(se->idstr, id) == 0 && se->opaque == opaque) {
>              QTAILQ_REMOVE(&savevm_handlers, se, entry);
> +            if (se->compat) {
> +                qemu_free(se->compat);
> +            }
>              qemu_free(se);
>          }
>      }
> @@ -1193,6 +1196,9 @@ void vmstate_unregister(DeviceState *dev, const 
> VMStateDescription *vmsd,
>      QTAILQ_FOREACH_SAFE(se, &savevm_handlers, entry, new_se) {
>          if (se->vmsd == vmsd && se->opaque == opaque) {
>              QTAILQ_REMOVE(&savevm_handlers, se, entry);
> +            if (se->compat) {
> +                qemu_free(se->compat);
> +            }
>              qemu_free(se);
>          }
>      }
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net