|
| From: | Paolo Bonzini |
| Subject: | [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable |
| Date: | Thu, 07 Oct 2010 09:20:37 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.3 |
On 10/06/2010 11:32 PM, Blue Swirl wrote:
Compiling with GCC 4.6.0 20100925 produced a warning: /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout': /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not used [-Werror=unused-but-set-variable] Fix by making the variable declaration and its uses also conditional to debug definition.
NACK, this uglifies the code and loses track of _what_ is that msgbyte we're reading.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |