[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed |
Date: |
Thu, 14 Oct 2010 13:58:08 -0600 |
On Thu, 2010-10-14 at 14:48 -0500, Anthony Liguori wrote:
> On 10/14/2010 02:44 PM, Jes Sorensen wrote:
> > On 10/14/10 20:33, Alex Williamson wrote:
> >
> >> We can't let the compiler define the alignment for qemu_cfg data.
> >>
> >> Signed-off-by: Alex Williamson<address@hidden>
> >> ---
> >>
> >> 0.13 stable candidate?
> >>
> > ACK I would say so.
> >
>
> fw_cfg interfaces are somewhat difficult to rationalize about for
> compatibility.
>
> 0.13.0 is tagged already so it's too late to pull it in there. If we
> say we don't care about compatibility at the fw_cfg level, then it
> doesn't matter if we pull it into stable-0.13. If we do care, then this
> is an ABI breaker.
If it works anywhere (I assume it works on 32bit), then it's only
because it happened to get the alignment right. This just makes 64bit
hosts get it right too. I don't see any compatibility issues,
non-packed + 64bit = broken. Thanks,
Alex
- [Qemu-devel] [PATCH] pc: e820 qemu_cfg tables need to be packed, Alex Williamson, 2010/10/14
- [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed, Jes Sorensen, 2010/10/14
- Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed, Anthony Liguori, 2010/10/14
- Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed,
Alex Williamson <=
- Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed, Anthony Liguori, 2010/10/14
- Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed, Arnd Bergmann, 2010/10/14
- Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed, Alex Williamson, 2010/10/14
- Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed, Arnd Bergmann, 2010/10/14
- Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed, Alex Williamson, 2010/10/15
[Qemu-devel] [PATCH v2] pc: e820 qemu_cfg tables need to be packed, Alex Williamson, 2010/10/15