qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed


From: Alex Williamson
Subject: Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed
Date: Thu, 14 Oct 2010 22:01:26 -0600

On Thu, 2010-10-14 at 23:19 +0200, Arnd Bergmann wrote:
> On Thursday 14 October 2010 22:59:04 Alex Williamson wrote:
> > The structs in question only contain 4 & 8 byte elements, so there
> > shouldn't be any change on x86-32 using one-byte aligned packing.
> 
> I'm talking about the alignment of the structure, not the members
> within the structure. The data structure should be compatible, but
> not accesses to it.
> 
> > AFAIK, e820 is x86-only, so we don't need to worry about breaking anyone
> > else.
> 
> You can use qemu to emulate an x86 pc on anything...

You're right, I wasn't thinking about non-x86 emulating x86.  I'll send
a v2 with your suggestion.  Thanks,

Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]