|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH]: VNC: set listener socket to non-blocking mode |
Date: | Thu, 21 Oct 2010 11:44:12 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100915 Lightning/1.0b1 Thunderbird/3.0.8 |
On 10/21/2010 11:18 AM, Gianni Tedesco wrote:
This prevents qemu from hanging waiting for a client to connect. I have reproduced this when doing a loadvm but it may be a more general problem in that poll/accept may race if a client aborts the connection with a RST before the accept has completed. In either case the fix seems harmless. Signed-off-by: Gianni Tedesco<address@hidden>
I'd feel a little better with explicit error handling in the accept() path and a comment explaining why this was necessary.
But otherwise, nice catch! Regards, Anthony Liguori
diff --git a/ui/vnc.c b/ui/vnc.c index 864342e..172b988 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2736,5 +2736,6 @@ int vnc_display_open(DisplayState *ds, const char *display) vs->display = dpy; } } + socket_set_nonblock(vs->lsock); return qemu_set_fd_handler2(vs->lsock, NULL, vnc_listen_read, NULL, vs); }
[Prev in Thread] | Current Thread | [Next in Thread] |