|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation |
Date: | Mon, 01 Nov 2010 20:43:54 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.4 |
On 11/01/2010 07:52 PM, Alexander Graf wrote:
@@ -237,6 +242,8 @@ static uint64_t elf_default_translate(void *opaque, uint64_t addr) ElfHandlers elf_default_handlers = { .translate_fn = elf_default_translate, .translate_opaque = NULL, + .note_fn = elf_default_note, + .note_opaque = NULL,Don't you have to add the definition to every user of translate_fn? Maybe it's better to guard calls through the pointers with an if.All users either pass NULL as translate (which means they default to elf_default_translate) or initialize their structure with the values in elf_default_translate :)
But do the MIPS users initialize note_fn? Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |