Re: [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers

[Miguel Di Ciurcio Filho]

On Mon, Dec 6, 2010 at 4:23 PM, Luiz Capitulino <address@hidden> wrote:
> Query handlers still carry their human monitor name. This commit
> renames all of them to a more QMP-like name.
>
> For example, do_info_version() is renamed to qmp_query_version().
> - * do_info_balloon(): Balloon information
> + * qmp_query_balloon(): Balloon information
>  *
>  * Make an asynchronous request for balloon info.  When the request completes
>  * a QDict will be returned according to the following specification:
> @@ -106,7 +106,7 @@ void monitor_print_balloon(Monitor *mon, const QObject 
> *data)
>  *   "major_page_faults": 142, "minor_page_faults": 239245,
>  *   "free_mem": 1014185984, "total_mem": 1044668416 }
>  */
> -int do_info_balloon(Monitor *mon, MonitorCompletion cb, void *opaque)
> +int qmp_query_balloon(Monitor *mon, MonitorCompletion cb, void *opaque)
>  {

If the idea is to detach the human monitor from the QMP API, is there
any reason to keep passing `Monitor *mon` to qmp_* functions? In some
parts of the code NULL is being passed.

Regards,

Miguel