Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

[Peter Maydell]

On 5 January 2011 23:13, Stuart Brady <address@hidden> wrote:
> I do have a few concerns regarding SoftFloat, though:
>
>   FIXMEs should be left in the code (or a document maintained on the
>   Wiki) to keep track of which architectures have been considered
>   (which I believe are x86, arm, mips, ppc) and which ones haven't.
>   This is in reference to one particular FIXME that was removed,
>   but perhaps shouldn't have been.

Which one? The only one I know I removed was the one in
the patch that implemented the thing it was complaining about,
but perhaps I took out another by accident...

>   Is there any plan to deal with use of float*_is_quiet_nan(), where
>   float*_is_any_nan() was intended?  These should really either be
>   fixed (and tested), or if not, a FIXME should be added.

I was planning to do the ARM related ones, at least (although
they are in the pretty-much-dead FPE-emulation code for
linux user-mode).

I would be more inclined to track that sort of thing in a bug tracker
than by sprinkling the code with FIXME comments.

-- PMM