Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

[Markus Armbruster]

Jes Sorensen <address@hidden> writes:

> On 01/24/11 17:08, Markus Armbruster wrote:
>> address@hidden writes:
>> 
>>> From: Jes Sorensen <address@hidden>
>>>
>>> Signed-off-by: Jes Sorensen <address@hidden>
>>> ---
>>>  cutils.c |   10 +++++-----
>>>  1 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/cutils.c b/cutils.c
>>> index 369a016..8d562b2 100644
>>> --- a/cutils.c
>>> +++ b/cutils.c
>>> @@ -324,26 +324,26 @@ int64_t strtosz_suffix(const char *nptr, char **end, 
>>> const char default_suffix)
>>>          }
>>>      }
>>>      switch (qemu_toupper(d)) {
>>> -    case 'B':
>>> +    case STRTOSZ_DEFSUFFIX_B:
>>>          mul = 1;
>>>          if (mul_required) {
>>>              goto fail;
>>>          }
>>>          break;
>>> -    case 'K':
>>> +    case STRTOSZ_DEFSUFFIX_KB:
>>>          mul = 1 << 10;
>>>          break;
>>>      case 0:
>>>          if (mul_required) {
>>>              goto fail;
>>>          }
>>> -    case 'M':
>>> +    case STRTOSZ_DEFSUFFIX_MB:
>>>          mul = 1ULL << 20;
>>>          break;
>>> -    case 'G':
>>> +    case STRTOSZ_DEFSUFFIX_GB:
>>>          mul = 1ULL << 30;
>>>          break;
>>> -    case 'T':
>>> +    case STRTOSZ_DEFSUFFIX_TB:
>>>          mul = 1ULL << 40;
>>>          break;
>>>      default:
>> 
>> Phony abstraction.  And it leaks: code here assumes the
>> STRTOSZ_DEFSUFFIX_T* are all upper case.
>
> qemu_toupper() - whats the problem?

If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case
will not match any input.