[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18)
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18) |
Date: |
Mon, 07 Feb 2011 08:56:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
[adding libvir-list as well]
On 02/07/2011 08:44 AM, Alon Levy wrote:
>>> I guess I'll wait a little longer for more feedback? Should I split
>>> the enum property separately? it's only used by ccid-card-emualted atm.
>>
>> The only non-cosmetic concern I have about your series is the enum
>> property so I would strongly suggest splitting it. If you did that
>> for v19, it will be pretty close to merge ready.
>>
>
> Eric,
>
> How does this affect libvirt? could you assume a default set of backends
> if "-device ccid-card-emulated,?" returns "backend=string" instead of
> "backend=A/B" ?
Hmm. At the moment, libvirt only looks for "ccid-card-emulated" in the
-device ? list, and hasn't yet tried inspecting -device
ccid-card-emulated,? output. In short, libvirt assumes that the
presence of ccid-card-emulated implies that both modes are available
(libvirt's <smartcard mode='host'/> => backend=nss-emulated; <smartcard
mode='host-certificates' => backend=certificates). Is it possible for
qemu to have support for one, but not both, of those modes? If that's
the case, then supporting "backend=nss-emulated/certificates" in -device
ccid-card-emulated,? would be handy for libvirt (for example, it would
be just "backend=certificates" if nss-emulated is not available). But
if it's an all-or-none approach (all backends are available if
ccid-card-emulated is present), then libvirt's current code won't be
impacted by changing the string to the simpler "backend=string".
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 12/16] ccid: add qdev description strings, (continued)
- [Qemu-devel] [PATCH 12/16] ccid: add qdev description strings, Alon Levy, 2011/02/03
- [Qemu-devel] [PATCH 13/16] smartcard, configure: add --enable-smartcard-nss, report only nss, Alon Levy, 2011/02/03
- [Qemu-devel] [PATCH 14/16] smartcard,configure: report only nss, Alon Levy, 2011/02/03
- [Qemu-devel] [PATCH 15/16] ccid-card-emulated: don't link with NSS if --disable-smartcard-nss, Alon Levy, 2011/02/03
- [Qemu-devel] [PATCH 16/16] ccid.h: add copyright, fix define and remove non C89 comments, Alon Levy, 2011/02/03
- [Qemu-devel] [PATCH 11/16] ccid: configure: add --enable/disable and nss only disable, Alon Levy, 2011/02/03
- [Qemu-devel] [PATCH 08/16] libcacard: initial commit, Alon Levy, 2011/02/03
- Re: [Qemu-devel] [PATCH 00/16] usb-ccid (v18), Alon Levy, 2011/02/07