Re: [Qemu-devel] [PATCH 21/28] migration: Make state definitions local

[Yoshiaki Tamura]

2011/2/24 Juan Quintela <address@hidden>:
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  migration.c |    8 ++++++++
>  migration.h |    8 --------
>  2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 493c2d7..697c74f 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -31,6 +31,14 @@
>     do { } while (0)
>  #endif
>
> +enum migration_state {
> +    MIG_STATE_ERROR,

Would be better to say:

MIG_STATE_ERROR = -1,

Yoshi

> +    MIG_STATE_NONE,
> +    MIG_STATE_CANCELLED,
> +    MIG_STATE_ACTIVE,
> +    MIG_STATE_COMPLETED,
> +};
> +
>  #define MAX_THROTTLE  (32 << 20)      /* Migration speed throttling */
>
>  static MigrationState current_migration = {
> diff --git a/migration.h b/migration.h
> index 3c5bb6a..e1fc921 100644
> --- a/migration.h
> +++ b/migration.h
> @@ -18,14 +18,6 @@
>  #include "qemu-common.h"
>  #include "notify.h"
>
> -enum migration_state {
> -    MIG_STATE_ERROR,
> -    MIG_STATE_NONE,
> -    MIG_STATE_CANCELLED,
> -    MIG_STATE_ACTIVE,
> -    MIG_STATE_COMPLETED,
> -};
> -
>  typedef struct MigrationState MigrationState;
>
>  struct MigrationState
> --
> 1.7.4
>
>
>