|
| From: | Michael Roth |
| Subject: | Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail |
| Date: | Fri, 01 Apr 2011 12:24:16 -0500 |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 |
On 04/01/2011 11:58 AM, Peter Maydell wrote:
On 1 April 2011 17:55, Michael Roth<address@hidden> wrote:But there *are* some warnings that make sense to complain about without saying "you can't do this", like extern's in .c files: some cases are exceptional.I'd treat everything checkpatch says as a warning anyway, because it gets confused by things like macros often enough that you can't guarantee that everything it thinks is an error is truly an error.
Well, we always have the option of ignoring the return code and just looking at the output. Would be nice to be able to automate the check somewhat reliably though, and just override the false positives when they pop up.
-- PMM
| [Prev in Thread] | Current Thread | [Next in Thread] |