[Qemu-devel] Re: [PATCH 3/5] atapi: GESN: Spin off No Event Available handling into own function

[Kevin Wolf]

Am 08.04.2011 09:15, schrieb Amit Shah:
> Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available status in its
> own function.
> 
> Also ensure the buffer the driver sent us is big enough to fill in all
> the data we have -- else just fill in as much as the buffer can hold.

This is unnecessary and in fact none of the IDE code does this.
s->io_buffer isn't guest memory, but an internal buffer that is
allocated like this:

s->io_buffer = qemu_memalign(2048, IDE_DMA_BUF_SECTORS*512 + 4);

So that's more than enough for storing four bytes. ide_atapi_cmd_reply()
takes care of making only max_size bytes visible to the guest.

Kevin