Re: [Qemu-devel] [PATCH v3 02/21] scsi-generic: Remove bogus double complete

[Christoph Hellwig]

On Tue, May 17, 2011 at 01:00:48PM +0200, Paolo Bonzini wrote:
> scsi-generic scsi_read_complete() should not -both- call the client
> complete callback with SCSI_REASON_DATA -and- call
> scsi_command_complete().  The former will cause the client to queue a
> new read or write request, while the later will free the request data
> structure, thus causing the new read or write request to use a
> freed/stale structure when it completes.
> 
> This patch fixes the bug, fixing a crash with scsi-generic & RHEL5.5
> installer.

Looks good,

Reviewed-by: Christoph Hellwig <address@hidden>